-
Notifications
You must be signed in to change notification settings - Fork 304
#54: Reveal describe details (tag name, number of commits) #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and git.build.version to the README
|
Sounds great, reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove all @author tags by the way, to make nier to feel collective ownership about the code. I'll do that. :-)
…code, also remove unused imports
|
Well I think we could make it static. |
|
Or better just pass the instance around ;) |
|
Mhh I think I would leave it as it is right now :-) |
|
Though I would much rather have it passed in from the "beginning of the control flow" (the plugin, or the test) let's go with the current impl for now ;-) |
#54: Reveal describe details (tag name, number of commits)
|
Thanks, merged! |
Hi @ktoso,
today I had some time to implement the feature for #54.
This PR looks huge but it isn't.
Most what I did was shifting code from DescribeCommand.java to a new class JGitCommon.java to make it easier accessible. This basically gave me the opportunity to reuse the major part of the functionality. We still could speed up the JGit-Implementation by saving the values we need twice but I leave this as optional :-9
Also I fixed the license-headers (some files had a duplicated license info) and added the new properties to the readme (I caught one that was missing...).
Let me know if I should improve something for the PR.
Thanks,