Fix stale-bot onlyLabels #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only labels mean "ALL of these labels has to be set" and not "one of these labels". So we had to change the label config.
mkllnk
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misunderstood the config for stale-bot sorry.
I thought of the onlyLabels as "one of these labels" has to be set, but in fact it is "ALL of these labels has to be set". And obviously we don’t have a single issue that has all these four labels (needs_info, question, ci, duplicate). So the bot might work but is not finding any issue to close.
So we had to change the label strategy for the bot and came up with this solution.