Unexpected error when trying to run unit test for exercise verification

[SAN-MUYUN]

I was running the unit test for some exercises and encountered a couple of issues.

1. incorrect test.sh script for developers using Windows.

This is a small issue. Since I am running on Windows, the code in test.sh may need to be changed to source venv/Scripts/activate instead of current source venv/bin/activate. Personally find it sufficient to just add this as a note for future developers.

2. repo_smith might have some issues deleting temporary files on Windows

This seems to be a more serious issue. After changing the test.sh script, unit testings still fail with unexpected errors. Parts of the error message is provided below. The entire error message is really long and cannot be fully captured.

Not sure of the exact reason for this error, but it seems like repo_smith is trying to delete a temporary file that was not properly closed and Windows stopped it.

Currently I am able to resolve this problem by adding a conftest.py file under tests folder for each exercise, containing codes generated by Claude.ai to safely close the files before repo_smith deletes it. If this fails, it ignores the error. Unit testings behave as expected after this file is added, but the temporary folders are not deleted. Not sure if there is a cleaner way to walk around this?

The conftest.py file is provided below.

conftest.py

OS: Windows 11 + Bash

[woojiahao]

@SAN-MUYUN I'll take a look at this this week!

[woojiahao]

repo-smith + git-autograder works by creating temporary folders to create the simulated folder structures, so that's a little bit of how it works.

Seems like this was a known issue on Windows: https://stackoverflow.com/questions/23566538/how-do-i-delete-a-temp-directory-on-windows-after-using-gitpython and more recently gitpython-developers/GitPython#387

[woojiahao]

Seems like this might be a fix? gitpython-developers/GitPython#546 (comment) Let me try to roll it out as a change

[woojiahao]

For the first issue you reported, we would likely need to make the test.sh script more flexible to read that it works on Windows.

The alternative for now, is to disable the auto activate, instead putting it as an instruction.

[woojiahao]

@SAN-MUYUN could you try to run pip install -r requirements.txt on the exercises repository and try test.sh again?

I have also updated the test.sh script to try enabling either venv/bin or venv/Script whichever is available.

[SAN-MUYUN]

@woojiahao I just tried again, following the intrustions that you provided, the same error persists. Tried test.sh on an already deployed exercise but still failed all test cases.

Running test.sh did not show error message for venv path so that update should be working fine :D

[woojiahao]

@SAN-MUYUN could you check what version of repo-smith you have now?

[SAN-MUYUN]

@woojiahao
current running Version 0.10.0

[woojiahao]

@SAN-MUYUN Ah yeah so it didn't get updated to the latest. Try to update to 0.10.1!

[SAN-MUYUN]

@woojiahao Yep! Updated to the latest version and now it is working perfectly! Thank you so much! :D

[woojiahao]

Fantastic, closing this issue now that it's fixed!