implement hands on hp-first-commit #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@SAN-MUYUN thank you for opening this! Sorry I missed it, I'll take a pass at it right now :) |
woojiahao
requested changes
Sep 25, 2025
Member
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
@SAN-MUYUN Thank you for contributing! Just a minor comment, otherwise LGTM!
hands_on/first_commit.py
Outdated
| def download(verbose: bool): | ||
| os.makedirs("things") | ||
| os.chdir("things") | ||
| run_command(["git", "init", "--initial-branch=main"], verbose) |
Member
There was a problem hiding this comment.
Could we use the init function in the exercise_utils.git package?
Contributor
Author
There was a problem hiding this comment.
Sure! I will make the necessary changes
Member
There was a problem hiding this comment.
Great! Thanks! I'll approve and merge :)
Member
|
@SAN-MUYUN would you like to give implementing an exercise a go? I think it'll be very doable! |
Contributor
Author
Sure! But I can only start working on it next week. Getting a little busy this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#52
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?