Skip to content
This repository was archived by the owner on Nov 1, 2025. It is now read-only.

Conversation

@onukura
Copy link
Member

@onukura onukura commented Aug 20, 2020

This PR add plugins below to the community list.
https://github.com/onukura/gitbucket-embedding-plugin

@takezoe takezoe merged commit d3194f6 into gitbucket-plugins:master Aug 20, 2020
@takezoe
Copy link
Contributor

takezoe commented Aug 20, 2020

Thanks! By the way, as you mentioned in README of this plugin, this feature might have to be implemented on GitBucket side. Do you have any concern about it?

@onukura
Copy link
Member Author

onukura commented Aug 20, 2020

@takezoe At first Thx for merge!

By the way, as you mentioned in README of this plugin, this feature might have to be implemented on GitBucket side. Do you have any concern about it?

Humm... This plugin just add JS on every page and have to search target DOM to replace with another DOM. So I thought it would be better for performance if it's done by renderer. Do you think snippet is ok with this way??

@onukura
Copy link
Member Author

onukura commented Aug 20, 2020

But at same time this way is useful too. It works every .markdown-body.p.a in issue, PR, wiki, repo/README.

@onukura
Copy link
Member Author

onukura commented Aug 21, 2020

@takezoe I think this discussion should be at gitbucket/gitbucket#2485. So I will put comment from now.

@takezoe
Copy link
Contributor

takezoe commented Aug 22, 2020

I think this discussion should be at gitbucket/gitbucket#2485. So I will put comment from now.

That makes sense. Let's discuss there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants