Skip to content

Conversation

@thelostone-mc
Copy link
Contributor

Used a bit of gpt to figure out how to handle the lock situation

  • Updated variable declarations for lock acquisition to avoid shadowing and improve readability.
  • Simplified lock acquisition and release logic, ensuring that all acquired locks are properly released in the finally block.
  • Added checks to release only the locks that were successfully acquired.

@linear
Copy link

linear bot commented Sep 9, 2024

@thelostone-mc thelostone-mc merged commit 9991715 into PAR-362 Sep 9, 2024
@thelostone-mc thelostone-mc deleted the PAR-367 branch September 9, 2024 09:27
thelostone-mc added a commit that referenced this pull request Sep 9, 2024
* update lock logic

* forceRelease of schema
thelostone-mc added a commit that referenced this pull request Sep 9, 2024
* update lock logic

* forceRelease of schema
thelostone-mc added a commit that referenced this pull request Sep 9, 2024
* update lock logic

* forceRelease of schema
0xKurt added a commit that referenced this pull request Sep 9, 2024
thelostone-mc pushed a commit that referenced this pull request Sep 9, 2024
* update schema name

* updates

* fix

* Revert "Refactor lock acquisition and release logic (#661)"

This reverts commit 9a2ffe1.
0xKurt pushed a commit that referenced this pull request Sep 11, 2024
* update lock logic

* forceRelease of schema
0xKurt added a commit that referenced this pull request Sep 11, 2024
* update schema name

* updates

* fix

* Revert "Refactor lock acquisition and release logic (#661)"

This reverts commit 9a2ffe1.
hussmartinez pushed a commit that referenced this pull request Sep 11, 2024
* update lock logic

* forceRelease of schema
hussmartinez pushed a commit that referenced this pull request Sep 11, 2024
* update schema name

* updates

* fix

* Revert "Refactor lock acquisition and release logic (#661)"

This reverts commit 9a2ffe1.
hussmartinez added a commit that referenced this pull request Sep 11, 2024
* have fallback IPFS

* feat: store ipfs data in db

* chore: move prices to it's own schema

* Refactor lock acquisition and release logic (#661)

* update lock logic

* forceRelease of schema

* index single chain (#657)

* update schema name

* updates

* fix

* Revert "Refactor lock acquisition and release logic (#661)"

This reverts commit 9a2ffe1.

* chore: avoid duplicate write + cleanup (#664)

* chore: avoid duplicate write

* cleanup

* improve locking (#665)

add forciblyAcquireLockForSchema

* test

* remove unused code

* add unique constraint

* chore: revert acquireWriteLock function

* f

* fix: args parser

---------

Co-authored-by: Kurt <kurt@merbeth.io>
Co-authored-by: Hussein Martinez <husse.dev@gmail.com>
gnomadic added a commit that referenced this pull request Sep 12, 2024
* stashing

* stashing

* feat: dogstatsd for indexer progress

* prettier

* cleanup

* iterating

* cleanup

* have fallback IPFS

* feat: store ipfs data in db

* chore: move prices to it's own schema

* Refactor lock acquisition and release logic (#661)

* update lock logic

* forceRelease of schema

* index single chain (#657)

* update schema name

* updates

* fix

* Revert "Refactor lock acquisition and release logic (#661)"

This reverts commit 9a2ffe1.

* chore: avoid duplicate write + cleanup (#664)

* chore: avoid duplicate write

* cleanup

* improve locking (#665)

add forciblyAcquireLockForSchema

* test

* remove unused code

* add unique constraint

* chore: revert acquireWriteLock function

* f

---------

Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
Co-authored-by: Kurt <kurt@merbeth.io>
Co-authored-by: Hussein Martinez <husse.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants