Add basic filtering functionality #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋 I stumbled across this repo a bit ago and love it! I wanted to try to add some filtering functionality as that seemed to be a missing feature. Mostly I just hated parsing all the entries on the /character response to get character ids for quotes. So I followed your contributing guidelines and gave it a shot.
Description
The changes on here are straightforward:
A client can pass any params related to the model schema to filter. Namely for strings we can do regex or exact match lookups like
/Gandalf/iorHuman.Design Issues
The filtering relies on the client to make the proper query, so parameters that do not match the model schemes are still processed and attempted to match, causing no results to be returned. Some APIs follow this paradigm and some don't but we can potentially change the config to blacklist these values or return errors on unmatched keys.
Let me know your thought on this whenever you get a chance.