Skip to content

Conversation

@MateuszKikmunter
Copy link
Collaborator

I added unit tests for the backend.
Now we have all controllers, most of the helpers and all middleware tested.
Additionally I also removed some unsed code and files and made some refactoring to make the code more modern.
Next step would be to add some integration tests to be fully covered. (I can work on that too if you agree @gitfrosh )

@EddieEldridge
Copy link
Contributor

EddieEldridge commented Feb 21, 2022

Had a quick look and all goods to me. This will be very helpful. If I had any feedback it would be

  • Move tests into their own dedicated folder (personal preference)
  • Add some documentation on how to run the tests to the README
  • Update package.json with the correct command to run the tests (if the existing one doesnt do it already)

@MateuszKikmunter
Copy link
Collaborator Author

MateuszKikmunter commented Feb 21, 2022

Had a quick look and all goods to me. This will be very helpful. If I had any feedback it would be

  • Move tests into their own dedicated folder (personal preference)
  • Add some documentation on how to run the tests to the README
  • Update package.json with the correct command to run the tests (if the existing one doesnt do it already)

Thanks for input @EddieEldridge !

  • I followed the general convention and placed the spec files close to the actual implementations.
  • There's a command for running tets in the package.json file, just go to the backend and run npm test.
  • Good point about README, thanks! :)

@MateuszKikmunter
Copy link
Collaborator Author

Please review and merge if all good @gitfrosh. I’ll move to the next issue afterwards. 😊

@EddieEldridge
Copy link
Contributor

Any chance this could get merged? It looks good to me and there's a few other bits I would like to work on using this functionality. Thanks.

@MateuszKikmunter
Copy link
Collaborator Author

MateuszKikmunter commented Jul 22, 2022

Any chance this could get merged? It looks good to me and there's a few other bits I would like to work on using this functionality. Thanks.

Same here. There are few things I’d like to take a look at after this PR is merged.

@gitfrosh gitfrosh merged commit 0569c75 into gitfrosh:release Jul 23, 2022
@gitfrosh
Copy link
Owner

Thank you @MateuszKikmunter and @EddieEldridge, for your contributions and reminders regarding the pull request! Finally, a proper test setup for the API 👍🏻 I'll merge this now, and you're very welcome to proceed with your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants