-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat: Add some backend tests #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add some backend tests #66
Conversation
|
Had a quick look and all goods to me. This will be very helpful. If I had any feedback it would be
|
Thanks for input @EddieEldridge !
|
|
Please review and merge if all good @gitfrosh. I’ll move to the next issue afterwards. 😊 |
|
Any chance this could get merged? It looks good to me and there's a few other bits I would like to work on using this functionality. Thanks. |
Same here. There are few things I’d like to take a look at after this PR is merged. |
|
Thank you @MateuszKikmunter and @EddieEldridge, for your contributions and reminders regarding the pull request! Finally, a proper test setup for the API 👍🏻 I'll merge this now, and you're very welcome to proceed with your work. |
I added unit tests for the backend.
Now we have all controllers, most of the helpers and all middleware tested.
Additionally I also removed some unsed code and files and made some refactoring to make the code more modern.
Next step would be to add some integration tests to be fully covered. (I can work on that too if you agree @gitfrosh )