Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of text in angle brackets in README.md #289

Closed
wants to merge 1 commit into from

Conversation

dilijev
Copy link

@dilijev dilijev commented Jul 18, 2019

Markdown incorrectly interpreted <commandname> as an HTML tag;
use backticks to escape Documentation/git-<commandname>.txt to ensure
that it renders the text as intended.

An alternative would be to HTML-escape the angle-brackets,
at the cost of readability of the markdown in plaintext form.
I opted for the backticks to preserve plaintext readability.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 18, 2019

Welcome to GitGitGadget

Hi @dilijev, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

Markdown incorrectly interpreted `<commandname>` as an HTML tag;
use backticks to escape `Documentation/git-<commandname>.txt` to ensure
that it renders the text as intended.

Signed-off-by: Doug Ilijev <doug.ilijev@gmail.com>
@dscho
Copy link
Member

dscho commented Jul 18, 2019

/allow dilijev

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 18, 2019

User dilijev is now allowed to use GitGitGadget.

@dilijev
Copy link
Author

dilijev commented Jul 18, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 18, 2019

Submitted as pull.289.git.gitgitgadget@gmail.com

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 18, 2019

On the Git mailing list, Jeff King wrote (reply to this):

On Thu, Jul 18, 2019 at 12:08:45PM -0700, Doug Ilijev via GitGitGadget wrote:

> Markdown incorrectly interpreted <commandname> as an HTML tag; use backticks
> to escape Documentation/git-<commandname>.txt to ensure that it renders the
> text as intended.
> 
> An alternative would be to HTML-escape the angle-brackets, at the cost of
> readability of the markdown in plaintext form. I opted for the backticks to
> preserve plaintext readability.

Yeah, I think backticks are the best solution; they match what we do
later in that same paragraph.

This kind of "an alternative..." explanation would go very well in the
actual commit message, too. :) Other than that nit, the patch looks good
to me.

-Peff

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 18, 2019

This branch is now known as di/readme-markup-fix.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 18, 2019

This patch series was integrated into pu via git@6fe281d.

@gitgitgadget gitgitgadget bot added the pu label Jul 18, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Jul 19, 2019

This patch series was integrated into pu via git@0c4e8f1.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 19, 2019

This patch series was integrated into next via git@339470d.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 23, 2019

This patch series was integrated into pu via git@15476e0.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 25, 2019

This patch series was integrated into pu via git@75ce486.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 25, 2019

This patch series was integrated into next via git@75ce486.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 25, 2019

This patch series was integrated into master via git@75ce486.

@gitgitgadget gitgitgadget bot added the master label Jul 25, 2019
@gitgitgadget gitgitgadget bot closed this Jul 25, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Jul 25, 2019

Closed via 75ce486.

@dilijev dilijev deleted the patch-1 branch July 30, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants