fix: use static key for runner matcher config (#4901) #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Copilot finished reviewing on behalf of
npalm
November 21, 2025 09:21
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a Terraform planning issue where the count for SSM parameters could not be calculated at plan time. The fix changes the runner_matcher_config map key from a computed value (aws_sqs_queue.queued_builds.id) to a static string ("default"), allowing Terraform to determine resource counts during the plan phase. Additionally, a spelling error in the documentation is corrected.
- Changed
runner_matcher_configmap key from dynamic SQS queue ID to static"default"string - Corrected spelling error "secreets" → "secrets" in documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.tf | Updated webhook module configuration to use static "default" key instead of dynamic SQS queue ID, enabling Terraform to calculate resource counts at plan time |
| modules/multi-runner/README.md | Fixed typo in ssm_paths variable description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koendelaat
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4901
This pull request updates the configuration for the webhook module by changing the key used in the
runner_matcher_configmap from the SQS queue ID to the string"default". This simplifies the configuration and makes it more explicit. This avoid a dynamic key is used and the count cannot be calculated.