Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Fixes to better control when the branch delete button is enabled #239

Merged
merged 6 commits into from
Aug 29, 2017
Merged

Fixes to better control when the branch delete button is enabled #239

merged 6 commits into from
Aug 29, 2017

Conversation

StanleyGoldman
Copy link
Contributor

Fixes #237
Fixes #238

  • Adding to the logic that controls when the delete button is diabled
  • Refactored the name of the method OnCreateGUI to OnButtonBarGUI
  • Refactored the strings in BranchesView to const

@StanleyGoldman StanleyGoldman requested a review from shana August 28, 2017 15:08
@StanleyGoldman StanleyGoldman mentioned this pull request Aug 28, 2017
Merged
1 task
@StanleyGoldman
Copy link
Contributor Author

#242 Depends on this

shana
shana approved these changes Aug 29, 2017
View reviewed changes
Copy link
Member

@shana shana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@shana shana merged commit 61c24f1 into master Aug 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@shana shana shana approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanleyGoldman @shana