This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Confirmation and Warning messages when checking out a remote branch #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
changed the title
shana
approved these changes
Aug 29, 2017
shana
reviewed
Aug 29, 2017
| var originName = selectedNode.Name.Substring(0, indexOfFirstSlash); | ||
| var branchName = selectedNode.Name.Substring(indexOfFirstSlash + 1); | ||
|
|
||
| if (Repository.LocalBranches.Any(localBranch => localBranch.Name == branchName)) |
There was a problem hiding this comment.
What we should be doing is checking if there's a branch that is tracking the same commit to determine whether the local branch exists, and offer to check that one out if it does. Probably something to consider for the future.
There was a problem hiding this comment.
Yea, I thought about that, I'll open up a future issue for that.
|
Oh boo. I messed up and this PR didn't target master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
Fixes #240
Depends on:
Fixes to better control when the branch delete button is enabled #239
Added confirmation message to checkout
Added warning message before checking out a remote branch when the local branch name exists