This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Always deleting octorun zip file when extracting #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until download functionality is implemented that checks the MD5, we should clear out the zip file before extracting.
This was referenced Mar 27, 2018
Merged
shana
approved these changes
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This is part of #663
After experimenting with PR #648 I realized that the plugin was unable to restore the original contents of the zip as found in master.
In the event of a version mismatch with octorun, the zip file that is currently in the extract from resources location is never changed/overwritten.
That possibly incorrect zip file is used to populate octorun everytime.