This repository was archived by the owner on Dec 5, 2024. It is now read-only.
0.31 rc #663
Merged
0.31 rc #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the process.exit to output.js - Updated command scripts to use output module correctly - Updated version and zip
Operational methods call the validation methods to validate data before they do their job. The validation methods load the requisite data and validate them. The operational methods then load the same data items and continue. In order to reduce the re-querying the validation methods now load the data, validate the data and returns the data if valid. Refactoring method `LoadKeychainInternal`/`ValidateKeychain` to `GetValidatedKeychainAdaper` Refactoring method `GetCurrentUserInternal` to `GetValidatedGitHubUser`
Credential might be null and we should be loading if there is no token
- LoadKeychainInternal is only called from ValidateKeychain - ValidateKeychain should throw a TokenUsernameMismatchException if it can see the user does not match
…n-missing-exception # Conflicts: # src/GitHub.Api/Application/ApiClient.cs # src/GitHub.Api/Authentication/Keychain.cs
Until download functionality is implemented that checks the MD5, we should clear out the zip file before extracting.
- Fix a bunch of typos - Make sure the download failing doesn't abort the whole process - Install lfs if there is a git but lfs is missing - Fix the download tests to download the real files that we're shipping - Mock the unzipper for the git installer test so it's faster - a bunch of other fixes
- Removing unused functions in BranchCache - Consolidating means to update BranchCache - Removing IsActive from GitBranch - Changing BranchesView to use RepositoryInfoCache in addition to BranchCache for it's display
The installation state was getting passed into ExtractPortableGit too early - that method needs to have the result of the download tasks
shana
approved these changes
Apr 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note by shana: Checkboxes reflect PR approvals