This repository was archived by the owner on Dec 5, 2024. It is now read-only.
ValidateGitInstall may fail in error #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
previously approved these changes
Mar 28, 2018
|
Yea, that works in theory, after some mac testing it doesn't work out when LFS is not found. |
StanleyGoldman
dismissed
shana’s stale review
You should probably look at this again..
This was referenced Mar 29, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This is part of #663
Fixes #656
Capturing a failure from ValidateGitInstall.
On Windows after picking something completely irrelevant.
On my Mac currently suffering from #650