This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Specifying dontUseGit when finding git #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
approved these changes
Apr 3, 2018
| @@ -120,7 +120,7 @@ public override void OnGUI() | |||
| CheckEnteredGitPath(); | |||
|
|
|||
| new FindExecTask("git", Manager.CancellationToken) | |||
| .Configure(Manager.ProcessManager) | |||
| .Configure(Manager.ProcessManager, false, true) | |||
There was a problem hiding this comment.
This should just be .Configure(Manager.ProcessManager, dontSetupGit: true) for readability and future-proofing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #664
Part of the problems identified in #659
When attempting to use the system's
where/whichcommand we should probably not modify the environmentPATHvariable. Especially when attempting to look for the system git.