This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Stop the UIController properly in the GitHubPane #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the logic of loading individual views that are not controlled by an UIController in the GitHubPane, so it's clearer what needs to happen and in which conditions.
|
Still have an annoying problem with the list sometimes not refreshing, even though it clearly changes. But otherwise, looking nice
|
| using ReactiveUI; | ||
| using System.Collections.Generic; | ||
| using System.Threading.Tasks; | ||
| using System.Diagnostics; |
There was a problem hiding this comment.
Looks like this isn't being used.
|
|
||
| if (!IsGitHubRepo.Value) | ||
| { | ||
| //LoadView(UIViewType.NotAGitHubRepo); |
There was a problem hiding this comment.
Doesn't look like this if statement is doing anything anymore, I uncommented to investigate and it looks like it's broken, do we intend to add NotAGitHubRepo to UIViewType at some point in the future?
There was a problem hiding this comment.
Yeah, it's a placeholder for @grokys to stuff things into 😄
|
This looks great 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure existing UI is stopped whenever the following conditions change:
Also make sure
Reloadis reentrant, all those await calls means it can get called multiple times.