Update to the latest version of @actions/github.
#221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
force-pushed
the
update-actions-github
branch
from
86d2402 to
9ed519f
Compare
robertbrignull
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Changes to our code look behaviour preserving. However I'm confused why not update the use in api-client.ts to github.getOctokit as well? It would seem to be the intended entrypoint to the library. I think you'd need to move the auth parameter field to a parameter instead of being in the options object, but otherwise it's entirely equivalent.
|
That's a fair point. It feels like a slightly ugly interface but I agree it probably makes sense to use it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully mean we get a newer version of Octokit and mean we can use Octokit plugins.
Merge / deployment checklist