Skip to content

Resolve violations of github/array-foreach lint #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2020
Merged

Resolve violations of github/array-foreach lint #223

merged 1 commit into from
Sep 21, 2020

Conversation

@miqh
Copy link
Contributor

@miqh miqh commented Sep 20, 2020

Hello,

These changes should remove the need to suppress the github/array-foreach lint in eslintrc.json.

Happy to fix up a few of the other linting issues if this submission looks alright.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

cbraynor
cbraynor approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@cbraynor cbraynor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging in - this looks great

@cbraynor cbraynor merged commit a8a6297 into github:main Sep 21, 2020
@miqh miqh deleted the fix/199 branch September 23, 2020 13:49
@github-actions github-actions bot mentioned this pull request Sep 28, 2020
Merged
@Elsokary22 Elsokary22 mentioned this pull request Jul 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cbraynor cbraynor cbraynor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miqh @cbraynor