Skip to content

Prioritizing pre-downloaded CodeQL bundle in some circumstances #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2020
Merged

Prioritizing pre-downloaded CodeQL bundle in some circumstances #227

merged 3 commits into from
Sep 23, 2020

Conversation

@cbraynor
Copy link
Contributor

@cbraynor cbraynor commented Sep 22, 2020 •
edited
Loading

This allows CodeQL bundles pre-included in the hosted runners to be used instead of the latest version if:

  • There is only one version in the tool cache
  • The version has been marked as pinned (related)
  • No explicit version has been provided with the tools flag (it will be honored)
  • The tools flag is not the specific literal latest (which will force using the latest version)

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Chris Raynor added 2 commits September 22, 2020 14:38
Allowing a cached version of the CodeQL bundle sometimes
41464b1 
To save time downloading the CodeQL bundle we're pre-downloading it into the
hosted Actions runner, but because the release schedule is different there may
be some version drift. This change allows a different version of the bundle
to be used than the default if a version isn't explicitly specified, there's
only one version downloaded, and it's been marked as a 'pinned-version' -
otherwise it reverts to the prior behavior.
Integration tests now both rely on pre-downloaded and latest codeql b…
3b90db9 
…undles
@cbraynor cbraynor marked this pull request as ready for review September 22, 2020 14:06
robertbrignull
robertbrignull approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get to reviewing this yesterday like I say I would.

Code changes LGTM. Couple of comments about the test workflows, but nothing major.

@cbraynor cbraynor merged commit 481f3ce into main Sep 23, 2020
@cbraynor cbraynor deleted the cbraynor/cache-pinning branch September 23, 2020 10:58
@github-actions github-actions bot mentioned this pull request Sep 28, 2020
Merged
This was referenced Apr 25, 2023
Open
Open
@Elsokary22 Elsokary22 mentioned this pull request Jul 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbraynor @robertbrignull