Skip to content

Resolve violations of eslint-comments/no-use lint #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2020
Merged

Resolve violations of eslint-comments/no-use lint #228

merged 2 commits into from
Sep 23, 2020

Conversation

@miqh
Copy link
Contributor

@miqh miqh commented Sep 23, 2020

Hello,

These changes should remove the need to suppress the eslint-comments/no-use lint in eslintrc.json.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

robertbrignull
robertbrignull approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking off another one.

@robertbrignull robertbrignull merged commit f2e557e into github:main Sep 23, 2020
@miqh miqh deleted the fix/197 branch September 23, 2020 22:27
@github-actions github-actions bot mentioned this pull request Sep 28, 2020
Merged
This was referenced Apr 25, 2023
Open
Open
@Elsokary22 Elsokary22 mentioned this pull request Jul 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miqh @robertbrignull