Resolve violations of no-sparse-arrays lint #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Don't know this array had double commas in it, but I've been through the history (including before it became open source) and it's been like this literally from the beginning.
Looking at where we use CRITICAL_TRACER_VARS I think this should have no behavioural change, or if it does then something very weird and confusing is going on.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
These changes should remove the need to suppress the
no-sparse-arrayslint ineslintrc.json.Merge / deployment checklist