Skip to content

Conversation

@miqh
Copy link
Contributor

@miqh miqh commented Sep 28, 2020

Hello,

These changes should remove the need to suppress the no-useless-escape lint in eslintrc.json.

I guess worth pointing out is the fact most characters are interpreted literally inside a character class regular expression rule, which is why this lint was complaining.


Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Copy link
Contributor

@cbraynor cbraynor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 thanks!

@cbraynor cbraynor merged commit 2841489 into github:main Sep 28, 2020
@miqh miqh deleted the fix/205 branch September 28, 2020 12:03
@github-actions github-actions bot mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants