Make URL parsing more robust, and handle subdomain isolation #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the runner's parsing of the URL a bit more robust and should make it handle the case where GHES is using subdomain isolation.
I need to test that this actually works and I will do so before merging, but from my prelimanary experimentation it looks like it should do as the
/api/v3route on the main GHES domain still seems to work. So we don't need to be able to reconstruct the isolated subdomain.The other changes to the URL parsing make it so if you don't pass a scheme then it'll assume it's
https. Also makes the output URL more consistent.Merge / deployment checklist