Skip to content

Conversation

@rneatherway
Copy link
Contributor

@rneatherway rneatherway commented Oct 8, 2020

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@robertbrignull
Copy link
Contributor

Release LGTM. Obviously all the tests pass, I've checked the logs and queries are not being compiled from scratch, and I've downloaded the artefact and given it a look too.

I am surprised that the codeql-runner artefacts have changed size. Down to 45MB from 70MB. I'm not sure why this is and they're still 70MB if I build them on my machine. The ones I download from the release still seem to work though.

@robertbrignull
Copy link
Contributor

I added a workflow to build and upload the runner artefacts: https://github.com/github/codeql-action/runs/1246905697?check_suite_focus=true

So they are 45MB when built on actions. Our hypothesis is that it's the node version. I have v13 on my machine here, whereas @rneatherway and actions are on v12, so this could be the reason. Regardless, I don't think this needs to hold up this release.

@rneatherway rneatherway merged commit bc19613 into main Oct 13, 2020
@rneatherway rneatherway deleted the rneatherway/codeql-bundle-20201008 branch October 13, 2020 10:14
@github-actions github-actions bot mentioned this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants