Skip to content

Don't use ::set-env in python-setup #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Don't use ::set-env in python-setup #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64ebf10
Don't use ::set-env in python-setup
RasmusWL Oct 8, 2020
bc72944
Merge branch 'main' into rasmuswl/python-update-setenv
RasmusWL Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python-setup/auto_install_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,5 +142,8 @@ def install_packages(codeql_base_dir) -> Optional[str]:
python_executable_path = install_packages(codeql_base_dir)

if python_executable_path is not None:
# see https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
env_file = open(os.environ["GITHUB_ENV"], mode="at")

print("Setting CODEQL_PYTHON={}".format(python_executable_path))
print("::set-env name=CODEQL_PYTHON::{}".format(python_executable_path))
print("CODEQL_PYTHON={}".format(python_executable_path), file=env_file)
8 changes: 6 additions & 2 deletions python-setup/tests/from_python_exe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python3

import sys
import os
import subprocess
from typing import Tuple

Expand All @@ -24,8 +25,11 @@ def get_details(path_to_python_exe: str) -> Tuple[str, str]:
if __name__ == "__main__":
version, import_path = get_details(sys.argv[1])

# see https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
env_file = open(os.environ["GITHUB_ENV"], mode="at")

print("Setting LGTM_PYTHON_SETUP_VERSION={}".format(version))
print("::set-env name=LGTM_PYTHON_SETUP_VERSION::{}".format(version))
print("LGTM_PYTHON_SETUP_VERSION={}".format(version), file=env_file)

print("Setting LGTM_INDEX_IMPORT_PATH={}".format(import_path))
print("::set-env name=LGTM_INDEX_IMPORT_PATH::{}".format(import_path))
print("LGTM_INDEX_IMPORT_PATH={}".format(import_path), file=env_file)