-
Couldn't load subscription status.
- Fork 412
Add a workflow to build and upload the runner #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I suggest just using codeql-action/.github/workflows/split.yml Lines 65 to 73 in ffaa8aa
Keep it separate though as |
1c7f052 to
d91d2d2
Compare
7636ec9 to
c1e2c53
Compare
|
I've tested this using the
Once this is merged I will delete the test release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, but otherwise it looks good to me.
| extension: ["linux", "macos", "win.exe"] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - uses: actions/checkout@v2 | |
| - uses: actions/checkout@v2 | |
| with: | |
| ref: refs/tags/${{ github.event.inputs.bundle-tag }} |
It's potentially confusing to build the code from main and upload it as an artifact on a tagged release.
(It would be nice if we could just use the workflow from the release tag too, but workflows can't be dispatched on tags currently.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed Robert's suggestion to make the bundle-tag optional, which now makes this a bit awkward. Do you see a way apart from having two calls to actions/checkout@2 each with an if?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interests of getting a version of this ready I am going to merge. We can later update this if we see a way to resolve the inconsistency.
|
Thanks for taking on the rest of this @rneatherway. |
…into robertbrignull/runner_workflow
52e7feb to
59913e8
Compare
Instead of building the runner locally we should probably standardise on building it within actions to get a consistent environment. This PR introduces a workflow that just builds the runner and upload the artefacts.
I'm intending this currently state as just a starting point. A couple of open questions I have are:
pushor justworkflow_dispatch? I only addedpushso I could test it before merging to the default branch.split.yml? The primary use case for this is when doing a release, but it could be useful to be able to run separatetly too.@rneatherway
Merge / deployment checklist