Add the --threads config option to finalize db #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not updated the README yet. I'll handle that soon. Also, any sort of unit tests or integration tests I should be adding or updating? |
aeisenberg
force-pushed
the
aeisenberg/threads-finalize
branch
from
b62a720 to
e5961ad
Compare
|
Also, there's a failing |
That's because you opened your PR from a fork and so the actions token doesn't have write scopes. You can just ignore the failure for this PR. |
robertbrignull
approved these changes
Nov 3, 2020
|
Thanks! Will resolve conflicts and rebase. |
This flag is already being used for `runQueries`, so let's use it for finalize as well.
aeisenberg
force-pushed
the
aeisenberg/threads-finalize
branch
from
e5961ad to
dd96eda
Compare
Merged
aofaof0907
pushed a commit
to aofaof0907/codeql-action
that referenced
this pull request
Jul 29, 2021
This flag is already being used for `runQueries`, so let's use it for finalize as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is already being used for
runQueries, so let's use it forfinalize as well.
Merge / deployment checklist