Fix invalid API call when running locally #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method getAnalysisKey would call getWorkflowPath and raise an API Error. This change follows the pattern in prepareLocalRunEnvironment to set a dummy value for the required environment variable, therefore shortcutting the API request.
simon-engledew
force-pushed
the
simon-engledew/fix-act-local
branch
from
81cccd1 to
5c0e2f9
Compare
Yes, exactly! 👍 Any attempts to access the API when local run is turned on automatically raise an Error. |
testing-utils.ts / setupTests() already stores and restores the env
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
getAnalysisKeywould callgetWorkflowPathand raise an API Error.This change follows the pattern in
prepareLocalRunEnvironmentto set a dummy value for the required environment variable, therefore shortcutting the API request.I have tried to mirror the existing mechanism for stubbing out
GITHUB_JOBas closely as possible.Merge / deployment checklist