Skip to content

Conversation

@rneatherway
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@robertbrignull
Copy link
Contributor

Seems to be fine. I'm happy to approve once the integration tests are reverted.

@rneatherway rneatherway force-pushed the rneatherway/bump-codeql-20201106 branch from f9fed27 to ab40235 Compare November 9, 2020 13:49
@rneatherway
Copy link
Contributor Author

Seems to be fine. I'm happy to approve once the integration tests are reverted.

Thanks, done

Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I assume you force pushed to an earlier commit that was already in the PR, so the notification comes through a bit weirdly 😆
Screenshot from 2020-11-09 13-57-16

@rneatherway rneatherway merged commit 4b301bd into main Nov 9, 2020
@rneatherway rneatherway deleted the rneatherway/bump-codeql-20201106 branch November 9, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants