Fix typos in source code, logging, comments, and config files #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename "toolrunnner" (three 'n') to "toolrunner" - Rename "relativeFilepaht" to "relativeFilepath" - Fix various typos in documentation & comments - Fix typos in logs and test names
src/autobuild-action.ts
Outdated
|
|
||
| interface AutobuildStatusReport extends actionsUtil.StatusReportBase { | ||
| // Comma-separated set of languages being autobuilt | ||
| // Comma-separated set of languages being autobuild |
There was a problem hiding this comment.
This one I'm not so sure about. It's debatable because "autobuild" or "autobuilt" are not really real words. I'd argue that "autobuilt" is more correct here since it would be correct if you removed the "auto" prefix. Maybe it would be more clear with a hyphen as "auto-built".
There was a problem hiding this comment.
Actually, this one is my mistake I would say. I think autobuilt would be "correct", but I like auto-built better 😃
|
Sorry I think you've conflicted with your own PR again (#310) |
|
Ah, snap! You just pushed. |
robertbrignull
approved these changes
Nov 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
This fixes typos in both the source code (variable names, logging, and comments) and a couple of config files (
.yml). Notable changes:src/fingerprints.test.tsdescriptionvalues were changed