Two minor code fixes #312
Merged
Two minor code fixes #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracer-config.test.js file contained a duplicate of the statement: process.env["SEMMLE_DEPTRACE_SOCKET"] = "abc"; one line apart. This removes the second instance of this statement.
Fix a minor issue in the update-release-branch.py script that performs a call to `sorted` but doesn't use the output. Since `sorted` does not operate in place, the call is currently useless. As a result, the function `get_pr_for_commit` does not currently work as exected. I.e. it is expected to return the "first" (i.e. lowest PR number), but actually it returns the first in the list provided by GitHub.
chrisgavin
approved these changes
Nov 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
This fixes two minor coding mistakes:
.github/update-release-branch.pythe output of a call tosortedwas not used.process.env["SEMMLE_DEPTRACE_SOCKET"] = "abc";one line apart from each other. I removed the latter.