Overlay: Fall back to full analysis if runner disk space is low #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
reviewed
Nov 18, 2025
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
One comment about the order of checks, otherwise I am happy to accept this as a conservative guard against regressions that might result from the increased space requirements.
kaspersv
force-pushed
the
kaspersv/overlay-disk-available-limit
branch
from
182eebd to
4eccb37
Compare
mbg
approved these changes
Nov 19, 2025
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback! I think is good to merge now.
One style comment, but not worth addressing here.
Comment on lines
+705
to
+720
| } else { | ||
| if (isAnalyzingPullRequest()) { | ||
| overlayDatabaseMode = OverlayDatabaseMode.Overlay; | ||
| useOverlayDatabaseCaching = true; | ||
| logger.info( | ||
| `Setting overlay database mode to ${overlayDatabaseMode} ` + | ||
| "with caching because we are analyzing a pull request.", | ||
| ); | ||
| } else if (await isAnalyzingDefaultBranch()) { | ||
| overlayDatabaseMode = OverlayDatabaseMode.OverlayBase; | ||
| useOverlayDatabaseCaching = true; | ||
| logger.info( | ||
| `Setting overlay database mode to ${overlayDatabaseMode} ` + | ||
| "with caching because we are analyzing the default branch.", | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Minor: This could now just be two else if blocks rather than an if/else inside an else block.
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fallback from overlay analysis to normal analysis if available runner disk space is low when deciding whether to perform overlay analysis during the
initaction. The fallback only applies when overlay analysis is enabled by feature flag and is ignored if overlay analysis is enabled by environment variable. The hardcoded limit of 20GB available disk space has been chosen based on telemetry from thecodeql-actionand will allow most +3m analysis runs to run in overlay mode.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning).analysis-kinds: code-quality).How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist