Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Nov 18, 2025

Bumps the glob dependency to at least version 11.1.0.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • Default setup - Impacts users who use default setup.
  • Code Scanning - Impacts Code Scanning (i.e. analysis-kinds: code-scanning).
  • Code Quality - Impacts Code Quality (i.e. analysis-kinds: code-quality).
  • Third-party analyses - Impacts third-party analyses (i.e. upload-sarif).
  • GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Nov 18, 2025
Copilot AI review requested due to automatic review settings November 18, 2025 10:50
@mbg mbg requested a review from a team as a code owner November 18, 2025 10:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

@github-actions github-actions bot added the size/XS Should be very easy to review label Nov 18, 2025
Copilot finished reviewing on behalf of mbg November 18, 2025 10:53
henrymercer
henrymercer previously approved these changes Nov 18, 2025
@mbg mbg force-pushed the mbg/deps/bump-glob branch from 8376857 to 528362a Compare November 18, 2025 12:20
@mbg mbg requested a review from henrymercer November 18, 2025 12:23
@mbg mbg enabled auto-merge November 18, 2025 12:37
@mbg mbg merged commit 70434f6 into main Nov 18, 2025
241 checks passed
@mbg mbg deleted the mbg/deps/bump-glob branch November 18, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants