Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Dec 3, 2025

Updates the codescanning-config-cli.yml workflow to account for the case where overlay analysis is enabled and the workflow runs for a pull request.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

CI.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner December 3, 2025 12:06
Copilot AI review requested due to automatic review settings December 3, 2025 12:06
@github-actions github-actions bot added the size/XS Should be very easy to review label Dec 3, 2025
Copilot finished reviewing on behalf of mbg December 3, 2025 12:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codescanning-config-cli.yml workflow to handle overlay analysis behavior on pull requests. The test now has separate variants for PR and non-PR events, since overlay analysis changes the CLI configuration on PRs by adding query filters.

  • Splits the "Empty file" test into two conditional variants based on event type
  • Adds expected query-filters configuration for PR events that includes the "exclude-from-incremental" tag filter

@mbg mbg force-pushed the mbg/ci/update-cs-config-cli-tests branch from 2c3655e to e225bc2 Compare December 3, 2025 12:10
@mbg mbg force-pushed the mbg/ci/update-cs-config-cli-tests branch from e225bc2 to d61a6fa Compare December 3, 2025 12:11
@mbg mbg enabled auto-merge December 3, 2025 12:27
@mbg mbg merged commit 78357d3 into main Dec 3, 2025
241 checks passed
@mbg mbg deleted the mbg/ci/update-cs-config-cli-tests branch December 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants