Skip to content

C++: remove upper-case variable name from HubClasses #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

C++: remove upper-case variable name from HubClasses #10417

merged 1 commit into from
Sep 14, 2022

Conversation

ginsbach
Copy link
Contributor

We are phasing our upper-case variable names: https://github.com/github/codeql-core/issues/2157

@ginsbach ginsbach requested a review from a team as a code owner September 14, 2022 13:51
@github-actions github-actions bot added the C++ label Sep 14, 2022
@ginsbach ginsbach added the no-change-note-required This PR does not need a change note label Sep 14, 2022
@ginsbach ginsbach changed the title upper-case variable names are deprecated remove upper-case variable name from HubClasses Sep 14, 2022
jketema
jketema approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. What I do not quite know is whether this might have any impact on things we do not test here (I'm not really familiar with the Architecture queries beyond knowing hat they exist). I propose we just merge this and see what happens.

@jketema jketema merged commit 6e74c32 into main Sep 14, 2022
@jketema jketema deleted the ginsbach/RemoveUpperCaseVariable branch September 14, 2022 14:50
@ginsbach ginsbach mentioned this pull request Sep 14, 2022
Merged
@jketema jketema changed the title remove upper-case variable name from HubClasses C++: remove upper-case variable name from HubClasses Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginsbach @jketema