C++: remove several upper-case NamedExpression variable names
#10420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginsbach
changed the title
NamedExpression variable names
jketema
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
As with the other PR: This looks ok to me. What I do not quite know is whether this might have any impact on things we do not test here (I'm not really familiar with the Architecture/Metrics queries beyond knowing hat they exist). I propose we just merge this and see what happens.
jketema
changed the title
NamedExpression variable namesNamedExpression variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous problem (#10417) was apparently just hiding more.