Skip to content

C++: remove several upper-case NamedExpression variable names #10420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ predicate hasInheritanceDepth(Class c, int d) {

from int depth
where hasInheritanceDepth(_, depth)
select depth as InheritanceDepth, count(Class c | hasInheritanceDepth(c, depth)) as NumberOfClasses
order by InheritanceDepth
select depth as inheritanceDepth, count(Class c | hasInheritanceDepth(c, depth)) as numberOfClasses
order by inheritanceDepth
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ where
100 * sum(Class c | c.fromSource() | c.getMetrics().getEfferentSourceCoupling()) /
sum(Class c | c.fromSource() | c.getMetrics().getEfferentCoupling())
).toString() + "%"
select l as Title, n as Value
select l as title, n as value
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ where
t.fromSource() and
n = t.getMetrics().getEfferentSourceCoupling() and
n > 10
select t as Class, "This class has too many dependencies (" + n.toString() + ")"
select t as class_, "This class has too many dependencies (" + n.toString() + ")"
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ where
n = f.getMetrics().getNumberOfCalls() and
n > 99 and
not f.isMultiplyDefined()
select f as Function, "This function makes too many calls (" + n.toString() + ")"
select f as function, "This function makes too many calls (" + n.toString() + ")"
2 changes: 1 addition & 1 deletion cpp/ql/src/Metrics/Namespaces/AbstractNamespaces.ql
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ where
n.fromSource() and
c = n.getMetrics().getAbstractness() and
c > 0.2
select n as Namespace, c as Abstractness order by Abstractness desc
select n as namespace, c as abstractness order by abstractness desc
2 changes: 1 addition & 1 deletion cpp/ql/src/Metrics/Namespaces/ConcreteNamespaces.ql
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ where
n.fromSource() and
c = n.getMetrics().getAbstractness() and
c = 0
select n as Namespace, c as Abstractness order by Abstractness desc
select n as namespace, c as abstractness order by abstractness desc
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ where
n.fromSource() and
c = n.getMetrics().getAfferentCoupling() and
c > 20
select n as Namespace, c as AfferentCoupling order by AfferentCoupling desc
select n as namespace, c as afferentCoupling order by afferentCoupling desc
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ where
n.fromSource() and
c = n.getMetrics().getDistanceFromMain() and
c > 0.7
select n as Namespace, c as DistanceFromMainline order by DistanceFromMainline desc
select n as namespace, c as distanceFromMainline order by distanceFromMainline desc
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ where
n.fromSource() and
c = n.getMetrics().getEfferentCoupling() and
c > 20
select n as Namespace, c as EfferentCoupling order by EfferentCoupling desc
select n as namespace, c as efferentCoupling order by efferentCoupling desc
2 changes: 1 addition & 1 deletion cpp/ql/src/Metrics/Namespaces/StableNamespaces.ql
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ where
n.fromSource() and
c = n.getMetrics().getInstability() and
c < 0.2
select n as Namespace, c as Instability order by Instability desc
select n as namespace, c as instability order by instability desc
2 changes: 1 addition & 1 deletion cpp/ql/src/Metrics/Namespaces/UnstableNamespaces.ql
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ where
n.fromSource() and
c = n.getMetrics().getInstability() and
c > 0.8
select n as Package, c as Instability order by Instability desc
select n as package, c as instability order by instability desc