-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Merge rc/1.20 into master #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the precense of multiple core libraries, `getAThrownException()` would return multiple copies of the same exception, say `System.OverflowException`, one for each core library. With this change we try to identify which core library a given control flow element was compiled against, and only return the corresponding version.
…ow `DataFlow::Configuration::isAdditionalFlowStep` to jump between callables.
When determining which core library a "tried control flow element" is compiled against, first look at exceptions caught by the surrounding `try` block, then look at assembly attributes, and finally choose (randomly) the core library with the highest lexicographic order.
Because this new library is not used in a default query, it needs to be imported here in order to be available in the LGTM query console.
…cking Approved by rdmarsh2
…ception C#: Reduce size of `getAThrownException()`
Approved by xiemaisi
JS: Omit uninteresting nodes from path explanations
…e-exposure Python: fix stack trace exposure query.
Fix qhelp backticks
C#: Model EntityFrameworkCore
C#: Model NHibernate framework
C#: Updated framework support list
Approved by esben-semmle, xiemaisi
CPP: Add references section to cpp/return-stack-allocated-memory
C#: Data flow performance improvements
jbj
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.