Ruby: try/try! as code execution #11022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmac
force-pushed
the
try-code-injection
branch
from
cbb5c67 to
0dd63c0
Compare
erik-krogh
approved these changes
Nov 7, 2022
| * `Object#try!` behaves similarly but raises `NoMethodError` if the | ||
| * receiver is not `nil` and does not respond to the method. | ||
| */ | ||
| class TryCallCodeExecution extends CodeExecution::Range, DataFlow::CallNode { |
There was a problem hiding this comment.
Suggested change
| class TryCallCodeExecution extends CodeExecution::Range, DataFlow::CallNode { | |
| class TryCallCodeExecution extends CodeExecution::Range instanceof DataFlow::CallNode { |
There was a problem hiding this comment.
👍 I'll open a new PR for this change to avoid having to ask for re-review on this one.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognise
Object#try(!)as a code execution. These methods are ActiveSupport extensions.Evaluation shows a slow-down forNew evaluation seems fine.canvas-lms, but I think that's because it contains a lot of calls totry(848 vs 389 forgitlabhq).