Ruby: Cosmetic change #11150
Merged
Ruby: Cosmetic change #11150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to user |
|
I don't really see how this is an improvement over the original but 🤷 |
erik-krogh
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
I don't really see how this is an improvement over the original but 🤷
It's not a big issue in Ruby, but in JS it can be a foot-gun.
E.g. our PropRead class is abstract, so using extends can be a real foot-gun.
So that a reason why I like to use instanceof instead of extends in cases like these.
|
Ah I see - for the same reason I believe we don't tend to use abstract classes much in Ruby outside of the Range pattern, so it's a bit more obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #11022 (comment)