Skip to content

Merge rc/3.8 into main #11612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Dec 8, 2022
Merged

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Dec 8, 2022

No description provided.

felicitymay and others added 30 commits November 29, 2022 09:19
(cherry picked from commit 174fbf6)
(cherry picked from commit 5d03892)
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Release preparation for version 2.11.5
…se-data-flow-analysis.rst

Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>
Co-authored-by: Michael B. Gale <mbg@github.com>
…cli-2.11.5

Post-release preparation for codeql-cli-2.11.5
LGTM deprecation: a few more references missed in earlier PRs
…ery-2

LGTM deprecation: Update basic queries to use VS Code
LGTM deprecation: Update QL detective tutorials
The old guide was based on the code duplication library, which no longer
works, and used screenshots of LGTM, which is deprecated.
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Docs: rewrite "defining the results of a query"
// Reachable by first following pathSoFar and then ferrying cargo
exists(string pathSoFar, string visitedStatesSoFar, Cargo cargo |
result = this.reachesVia(pathSoFar, visitedStatesSoFar).safeFerry(cargo) and
not exists(int i | i = visitedStatesSoFar.indexOf(result)) and // resulting state is not visited yet

Check warning

Code scanning / CodeQL

Expression can be replaced with a cast

The assignment in the exists(..) is redundant.
State reachesVia(string path) {
exists(string pathSoFar |
result = this.reachesVia(pathSoFar).transition() and
not exists(int i | i = pathSoFar.indexOf(result.toString())) and

Check warning

Code scanning / CodeQL

Expression can be replaced with a cast

The assignment in the exists(..) is redundant.
State reachesVia(string path) {
exists(string pathSoFar |
result = this.reachesVia(pathSoFar).transition() and
not exists(int i | i = pathSoFar.indexOf(result.toString())) and

Check warning

Code scanning / CodeQL

Expression can be replaced with a cast

The assignment in the exists(..) is redundant.
}

override State reachesVia(string path) {
path = this + "\n" + result and result = transition()

Check warning

Code scanning / CodeQL

Using implicit `this`

Use of implicit `this`.
}

override State reachesVia(string path) {
path = this + "\n↓\n" + result and result = transition()

Check warning

Code scanning / CodeQL

Using implicit `this`

Use of implicit `this`.
}
}

/** One of two shores. */

Check warning

Code scanning / CodeQL

Class QLDoc style.

The QLDoc for a class should start with 'A', 'An', or 'The'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants