Skip to content

Java/Python: use Number.qll to parse hex numbers in regex parsing #12550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

Java/Python: use Number.qll to parse hex numbers in regex parsing #12550

merged 2 commits into from
Mar 20, 2023

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Mar 16, 2023 •
edited
Loading

My own followup to #12169

Evaluations look uneventful: Python, Java.

@erik-krogh erik-krogh marked this pull request as ready for review March 16, 2023 13:33
@erik-krogh erik-krogh requested review from a team as code owners March 16, 2023 13:33
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Mar 16, 2023
atorralba
atorralba previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java LGTM

@erik-krogh erik-krogh mentioned this pull request Mar 17, 2023
Merged
@calumgrant calumgrant requested a review from yoff March 20, 2023 10:06
yoff
yoff approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@erik-krogh erik-krogh merged commit a9d40d3 into github:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoff yoff yoff approved these changes

+1 more reviewer

@atorralba atorralba atorralba left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erik-krogh @yoff @atorralba