Java/C# : Enhance provenance. #12595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelnebel
force-pushed
the
enhanceprovenance
branch
from
0c58868 to
53eb5cb
Compare
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
Fixed
Show fixed
Hide fixed
java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll
Fixed
Show fixed
Hide fixed
michaelnebel
force-pushed
the
enhanceprovenance
branch
6 times, most recently
from
dbc15a5 to
dbfc711
Compare
hvitved
reviewed
Mar 24, 2023
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
michaelnebel
force-pushed
the
enhanceprovenance
branch
2 times, most recently
from
803d53a to
0971e69
Compare
michaelnebel
added
the
no-change-note-required
|
All Java |
Yes, that is a good idea! I will do that! |
jcogs33
reviewed
Mar 28, 2023
michaelnebel
force-pushed
the
enhanceprovenance
branch
from
0607581 to
ff91556
Compare
michaelnebel
force-pushed
the
enhanceprovenance
branch
from
ff91556 to
7345a77
Compare
…el generator printing to the new provenance.
michaelnebel
force-pushed
the
enhanceprovenance
branch
from
7345a77 to
169d8d5
Compare
|
DCA looks good. |
hvitved
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update the provenance related information in a non-backwards compatible way.
The new possible values for the provenance is
originandverification, whereoriginis eitherdf(data flow model generator),tp(type based model generator),hq(heuristic query) orai(AI generated) andverificationis eithermanualorgenerated.Examples of provenances are
This means that by manual inspection of a model one can change the verification from “generated” -> “manual”).
@lcartey : This change is not backwards compatible. All generated models needs to be have their provenance changed from "generated" -> "df-generated".