JS: extract YAML library to a shared pack #12780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
reviewed
Apr 12, 2023
erik-krogh
reviewed
Apr 12, 2023
erik-krogh
reviewed
Apr 12, 2023
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
aibaars
force-pushed
the
shared-yaml-lib
branch
from
07add5f to
ead8108
Compare
erik-krogh
reviewed
Apr 17, 2023
There was a problem hiding this comment.
LGTM 👍
The change should be very non-breaking, as long as you don't do weird extends / @overrides.
But it still deserves a chance-note that a new shared YAML library has been added.
Also, I've written some of this, so I think you should get someone else from dynamic to also approve this PR.
|
And a change-note in the |
erik-krogh
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the YAML library used by JavaScript into a shared QL pack to make it re-usable by other languages.