Skip to content

JS: extract YAML library to a shared pack #12780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 18, 2023
Merged

JS: extract YAML library to a shared pack #12780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f0b5f9c
Shared YAML library
aibaars Apr 6, 2023
4fca4b6
JS: use shared YAML library
aibaars Apr 6, 2023
b5e9048
improve the ESLint model to avoid overriding Yaml classes
erik-krogh Apr 11, 2023
3c4bd5b
forward toString() etc. predicates from YamlNode to Locatable
erik-krogh Apr 11, 2023
83cd55c
Js/Yaml: add getFile() predicate
aibaars Apr 11, 2023
ead8108
Apply suggestions from code review
aibaars Apr 13, 2023
34d3040
Add change note
aibaars Apr 17, 2023
048fb8b
Add change note
aibaars Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/ql/lib/change-notes/2023-04-17-shared-yaml-lib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: majorAnalysis
---
* The Yaml.qll library was moved into a shared library pack named `codeql/yaml` to make it possible for other languages to re-use it. This change should be backwards compatible for existing JavaScript queries.
1 change: 1 addition & 0 deletions javascript/ql/lib/qlpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ dependencies:
codeql/regex: ${workspace}
codeql/tutorial: ${workspace}
codeql/util: ${workspace}
codeql/yaml: ${workspace}
dataExtensions:
- semmle/javascript/frameworks/**/model.yml
2 changes: 1 addition & 1 deletion javascript/ql/lib/semmle/javascript/PrintAst.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private predicate isNotNeeded(Locatable el) {
private string getQlClass(Locatable el) {
result = "[" + el.getPrimaryQlClasses() + "] "
// Alternative implementation -- do not delete. It is useful for QL class discovery.
// not el.getAPrimaryQlClass() = "???" and result = "[" + getPrimaryQlClasses() + "] " or el.getAPrimaryQlClass() = "???" and result = "??[" + concat(el.getAQlClass(), ",") + "] "
// not el.getAPrimaryQlClass() = "???" and result = "[" + el.getPrimaryQlClasses() + "] " or el.getAPrimaryQlClass() = "???" and result = "??[" + concat(el.getAQlClass(), ",") + "] "
}

/**
Expand Down
Loading