[Java] Implement field taint inheritance for Struts2 unmarshalled objects #13713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that we're properly tracking taint through fields, the fact that By changing it to be a |
atorralba
force-pushed
the
java/struts2_source_taint_inheriting
branch
from
908c1d0 to
c239a43
Compare
atorralba
added
the
depends on internal PR
added 2 commits
July 28, 2023 12:05
….com/pwntester/codeql into java/struts2_source_taint_inheriting
atorralba
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQl already models Struts2 unmarhaled objects as a source of untrusted data. Unfortunately, the source is at the object level and their direct and object graph nested fields are not tainted. This PR implements a FieldContent TaintInheriting class for each field in the unmarhaled objects object graph.