Java: Allow flow out of FieldValueNodes for non-static fields #13817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCA looks uneventful. |
aschackmull
reviewed
Jul 26, 2023
java/ql/lib/change-notes/2023-07-26-flow-out-nonstatic-fields.md
Outdated
Show resolved
Hide resolved
atorralba
force-pushed
the
atorralba/java/non-static-fieldvaluenode-step
branch
from
5df245a to
602eb43
Compare
As it should be. On its own it should not be possible for this change to affect any flow anywhere - it requires a source definition that's a FieldValueNode in order to have an effect. |
atorralba
force-pushed
the
atorralba/java/non-static-fieldvaluenode-step
branch
from
f617f30 to
8685242
Compare
|
@aschackmull I added some tests. If you don't mind, please re-approve. |
aschackmull
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, directly tainting
FieldValueNodesof non-static fields is useful (e.g. sources). With this change, we allow flow out of them even if their field isn't static.