Skip to content

Java: Add XXE sinks for MDHT #13773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

atorralba
Copy link
Contributor

@atorralba atorralba commented Jul 19, 2023

Adds sinks for the CDAUtil.load and CDAUtil.loadAs methods of https://github.com/mdht/mdht.

This helps covering CVE-2023-22832.

@atorralba atorralba force-pushed the atorralba/java/mdht-xxe-sink branch from 2c8fdfe to d64ad8e Compare July 19, 2023 11:06
@atorralba atorralba force-pushed the atorralba/java/mdht-xxe-sink branch from d64ad8e to 2cbb7ed Compare July 31, 2023 09:13
@atorralba atorralba marked this pull request as ready for review July 31, 2023 09:17
@atorralba atorralba requested a review from a team as a code owner July 31, 2023 09:17
@atorralba
Copy link
Contributor Author

The compilation CI error has nothing to do with this PR and is fixed by #13853.

Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't looked at all the stub files, but I assume those are fine.

@atorralba
Copy link
Contributor Author

LGTM. I haven't looked at all the stub files, but I assume those are fine.

They were auto-generated, so they should be. Thanks!

@atorralba atorralba merged commit 0f3918a into github:main Aug 23, 2023
@atorralba atorralba deleted the atorralba/java/mdht-xxe-sink branch August 23, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants