Skip to content

Ruby: No fieldFlowBranchLimit for SummarizedCallables #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Feb 22, 2024

This PR adds a hook to the data flow library to allow for certain callables to excluded from the field-flow-branch-limit restriction.

For Ruby, we want to always include flow into/out of summarized callables, as these are expected to have high precision, which will ultimately reduce false negatives.

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Feb 22, 2024
@hvitved hvitved marked this pull request as ready for review February 22, 2024 16:14
@hvitved hvitved requested a review from a team as a code owner February 22, 2024 16:14
@hvitved hvitved requested a review from aschackmull February 22, 2024 19:55
@hvitved hvitved merged commit 9411352 into github:main Feb 23, 2024
@hvitved hvitved deleted the ruby/no-field-branch-limit-summarized-callable branch February 23, 2024 09:48
yoff added a commit to yoff/codeql that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFlow Library no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants